Re: [PATCH 2/4] dt-bindings: thermal: Add Tegra264 header
From: Krzysztof Kozlowski
Date: Mon Aug 31 2026 - 03:14:06 EST
On Thu, Aug 27, 2026 at 06:33:06PM +0100, Conor Dooley wrote:
> On Thu, Aug 27, 2026 at 07:17:15PM +0200, Thierry Reding wrote:
> > On Thu, Aug 27, 2026 at 05:35:28PM +0100, Conor Dooley wrote:
> > > On Thu, Aug 27, 2026 at 05:07:51PM +0200, Thierry Reding wrote:
> > > > From: Thierry Reding <treding@xxxxxxxxxx>
> > > >
> > > > This header file defines the set of thermal zones exposed by the BPMP on
> > > > Tegra264.
> > >
> > > Does this need to be a binding, since you're just using it in the dts?
> > > Can it just go into your dts directory insteaD?
> >
> > I don't think we've ever used these headers outside of DTS files, so,
> > yes, they could go into the DTS directory.
> >
> > We've never done that before and there's a bunch of Tegra-specific files
> > that would be in the same basket. What's your recommendation for any of
> > the existing headers? Should I move those into the DTS directory, too?
> > If they are not used outside, that is? Or not worth the churn?
>
> Up to you re: churn I think, but were it my platform I'd probably move
> them.
For Samsung I moved all non-ABI related headers to DTS. I think one more
platform followed. Moving needs to keep old header for some time anyway,
so it's entirely up to you if you/others want to work on that. Like with
every less-important cleanup, the benefit is that correcting old
patterns stops encouraging repeating them.
Best regards,
Krzysztof