Re: [PATCH v4 1/4] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

[Krzysztof Kozlowski]

On Thu, Aug 27, 2026 at 11:00:33PM -0700, Qiang Yu wrote:
> The QREF block supplies reference clocks to PCIe/USB/UFS PHYs and requires
> dedicated LDO supplies to operate. The digital control interface for QREF
> (clkref_en registers) resides in TCSR on x1e80100. Since QREF has no
> dedicated DT node of its own, these supply properties are placed in the
> TCSR node which acts as the control interface for QREF.
> 
> These LDOs are required by QREF to provide a stable reference clock,
> without which the USB/PCIe/eDP PHYs cannot work properly, so the supplies
> are marked required even though it breaks ABI.
> 
> TCSR does not act as a reset provider on x1e80100: no driver has ever
> registered a reset controller for it, and no consumer references it as a
> reset, so #reset-cells is dropped entirely rather than documented.
> 
> Add a dedicated binding file for qcom,x1e80100-tcsr and document the
> supply properties.
> 
> Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,sm8550-tcsr.yaml           |   1 -
>  .../bindings/clock/qcom,x1e80100-tcsr.yaml         | 114 +++++++++++++++++++++
>  2 files changed, 114 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof