Re: [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY

[Mattijs Korpershoek]

Hi Krzysztof,

Thank you for the review.

On Tue, Aug 04, 2026 at 10:08, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On 22/07/2026 15:45, Mattijs Korpershoek wrote:
>> +  power-domains:
>> +    maxItems: 2
>> +
>> +  power-domain-names:
>> +    items:
>> +      - const: transfer
>> +      - const: core
>> +
>
> Same comments, why isn't this following established naming practice for
> sa8xxx bindings?

I've replied in the other phy driver review at:
https://lore.kernel.org/all/877blx2bga.fsf@xxxxxxxxxx/

I've also send a new version for those bindings which hopefully better
document the power-domain-names and their usage:
https://lore.kernel.org/all/20260831-phy-qcom-snps-femto-v2-8255-v2-1-dc6197ffde1b@xxxxxxxxxx/

I'll focus on sa8255p-usb-hs-phy.yaml. Once we have something that's
acceptable for usb-hs, I'll respin this series as well.

Thanks
Mattijs

>
> Best regards,
> Krzysztof