Re: [PATCH v4 08/15] media: ov2740: support 288 MHz link frequency
From: Andy Shevchenko
Date: Mon Aug 31 2026 - 05:51:35 EST
On Fri, Aug 28, 2026 at 06:14:50PM +0200, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91 front camera uses two CSI-2 lanes at a
> 288 MHz link frequency. Add the matching PLL configuration and mode
> timing.
>
> Reuse the existing 1932x1092 crop and mode register list so the Bayer
> order remains SGRBG across link frequencies. Cropping the CSI-2
> receiver output to a smaller processed frame is a userspace pipeline
> decision.
> Link: https://lore.kernel.org/linux-media/apFzAc5XfV9gQpXS@kekkonen.localdomain/
> Link: https://lore.kernel.org/linux-media/apF0Cds9fnqQ7XRg@kekkonen.localdomain/
No, you shouldn't add these tags. You can refer to the URLs in a free form in
the comment block, and not in the commit message.
> Assisted-by: Codex:gpt-5.6-sol sparse
> ---
Comment block is here.
...
> #define OV2740_SCLK 72000000LL
> -#define OV2740_MCLK 19200000
> +#define OV2740_MCLK (192 * HZ_PER_MHZ / 10)
720 is left untouched so should this.
--
With Best Regards,
Andy Shevchenko