Re: [PATCH v1] serial: qcom-geni: Fix port_ida handling for console and probe errors

[Aniket RANDIVE]

Thanks Konrad for the review.

On 8/31/2026 12:58 PM, Konrad Dybcio wrote:
> On 8/28/26 1:14 PM, Aniket Randive wrote:
> > The console port uses a fixed line number and is not allocated from
> > port_ida. However, qcom_geni_serial_remove() unconditionally frees the
> > line number for all ports, including the console port.
> >
> > Skip ida_free() for console ports so that only IDs allocated from
> > port_ida are returned.
> >
> > Also release allocated IDs from the common probe error path. Currently,
> > IDs are freed only on the wake-IRQ failure path, causing leaks when
> > probe fails after a successful allocation. Move the ida_free() call to
> > the common error path and guard it for console ports.
> >
> > Signed-off-by: Aniket Randive <aniket.randive@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/tty/serial/qcom_geni_serial.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> > index 3633723acef8..3bfe597d2c83 100644
> > --- a/drivers/tty/serial/qcom_geni_serial.c
> > +++ b/drivers/tty/serial/qcom_geni_serial.c
> > @@ -1979,7 +1979,6 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
> >   						port->wakeup_irq);
> >   		if (ret) {
> >   			device_init_wakeup(&pdev->dev, false);
> > -			ida_free(&port_ida, uport->line);
> >   			goto error;
> >   		}
> >   	}
>
> GPT suggested that the failure of
>
> ret = port->dev_data->resources_init(&port->se);
>
> should also be updated to have a 'goto error' rather than a direct
> return

Good catch. I will fix in next V2 patch. I will route through "error" 
now so it goes through the same ida_free() as every other failure path 
instead of skipping it.

> also that in get_port_from_line(), reordering the devm_kzalloc before
> ida_alloc_range() would prevent another leak

Agree. I will reorder it.

> Konrad