Re: [PATCH 1/2] stacktrace: Provide arch_in_irqentry_text() hook

From: Bradley Morgan

Date: Mon Aug 31 2026 - 08:14:11 EST


On 31 August 2026 13:06:19 BST, Yuanhe Shu <xiangzao@xxxxxxxxxxxxxxxxx>
wrote:
>On Thu, Aug 27, 2026 at 06:04:48PM +0100, Bradley Morgan wrote:
>> LGTM, thanks
>>
>> Reviewed-by: Bradley Morgan <brads@xxxxxxxxxxxxxx>
>
>Thanks for reviewing v1. I dropped the tag in v2 since the patch changed
>materially: Peter asked for the #ifndef macro override pattern instead of
>a Kconfig symbol, so the hook and its fallback now sit next to their only
>user in kernel/stacktrace.c and x86 defines the macro in <asm/sections.h>.
>The helper and the hook are also renamed to in_event_entry_text() and
>arch_in_event_entry_text(). Please have another look if you get the
>chance:
>
>

Hmmm. Good opinion, it's varied imho. But I'm not conflicted. My tag
stands.
https://lore.kernel.org/r/20260831120221.2874445-1-xiangzao@xxxxxxxxxxxxxxxxx
>
>Thanks,
>Yuanhe

--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@xxxxxxxxx/