Re: [PATCH v6 04/13] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250

[Bjorn Andersson]

On Mon, Aug 24, 2026 at 03:01:47PM +0000, Sreeshankar K wrote:
> Add support for the global clock controller found on SM7250
> based devices. This should allow most non-multimedia device
> drivers to probe and control their clocks.

"This should"?

> 
> Signed-off-by: Sreeshankar K <sreeshankar0910@xxxxxxxxx>
[..]
> diff --git a/drivers/clk/qcom/gcc-sm7250.c b/drivers/clk/qcom/gcc-sm7250.c
[..]
> +	.clk_regs_configure = gcc_sm7250_clk_regs_configure,

/home/bjorn/sandbox/kernel/workspace/drivers/clk/qcom/gcc-sm7250.c:2228:24: error: incompatible function pointer types initializing 'void (*)(struct device *, struct regmap *)' with an expression of type 'void (struct regmap *)' [-Wincompatible-function-pointer-types]
 2228 |         .clk_regs_configure = gcc_sm7250_clk_regs_configure,
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Thank you,
Bjorn

> +};