Re: [PATCH] staging: axis-fifo: fix underflow of tx_fifo_depth in size check

From: Manush Prajwal

Date: Tue Sep 01 2026 - 10:34:17 EST


On Tue, Sep 01, 2026 at 10:06:00AM +0530, Greg KH wrote:
> So this is just a bug in the device tree?
>
> How was this found and tested?

You're right, and I should have said this up front instead of making
you ask.

This was found by static source review with AI assistance (Claude),
not from a real fault report, fuzzing, or anything hit on actual
hardware. It was checked with checkpatch --strict and verified to
apply cleanly against a fresh clone, but it was never build-tested
against a real kernel build or run on axis-fifo hardware.

On reflection your first question is the real issue: tx-fifo-depth
comes from the devicetree, which is trusted input describing the
hardware, not attacker-controlled data crossing a security boundary.
A DT that lies about the FIFO depth is a bug in that DT, not
something the driver needs to defend against. I don't think this
patch is worth carrying -- happy to drop it.

> Did you forget to add an Assisted-by: tag for this patch?

Yes -- I should have disclosed the AI assistance in the commit
message itself rather than leaving it for you to notice and ask
about. Apologies for that, and thank you for calling it out
directly.

Manush