RE: [PATCH 06/10] dt-bindings: clock: Add r8a774a3 CPG Core Clock definitions

[Ayman Chaudhry]

Hi Krzysztof,

Thanks for your review.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Saturday, August 22, 2026 8:31 AM
> To: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>; Geert
> Uytterhoeven <geert+renesas@xxxxxxxxx>; magnus.damm
> <magnus.damm@xxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Stephen Boyd <sboyd@xxxxxxxxxx>; Brian Masney
> <bmasney+clk@xxxxxxxxxx>; Jerome Brunet <jbrunet+clk@xxxxxxxxxxxx>;
> Ulf Hansson <ulfh@xxxxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx;
> Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; Biju Das
> <biju.das.jz@xxxxxxxxxxxxxx>; Fabrizio Castro
> <fabrizio.castro.jz@xxxxxxxxxxx>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 06/10] dt-bindings: clock: Add r8a774a3 CPG Core Clock
> definitions
> 
> On 21/08/2026 17:03, Ayman Chaudhry wrote:
> > Add all the Renesas RZ/G2M v3.0 (a.k.a. R8A774A3) SoC Clock Pulse
> > Generator Core Clock Outputs, as listed in Table 11.3 ("List of Clocks
> > [RZ/G2M V1.3, RZ/G2M V3.0]") of the RZ/G2 Hardware User's Manual.
> >
> > Signed-off-by: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>
> > ---
> >  include/dt-bindings/clock/r8a774a3-cpg-mssr.h | 59
> > +++++++++++++++++++
> 
> Same comments. Why are you using discouraged naming and why are you
> sending it SEPARATELY from the binding?
> 

Agreed, I will update the naming in v2.

Similarly to the SYSC binding, this is already present in the kernel:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b3b9cdb7db191ba262256972d08802b7bd8c7d4

Kind Regards,
Ayman

> 
> Best regards,
> Krzysztof