Re: [PATCH v3 4/4] of: address: kill of_node_is_pcie()

From: Alex Elder

Date: Tue Sep 01 2026 - 11:25:34 EST


On 9/1/26 10:15 AM, Herve Codina wrote:
The warning here was printed based on the node name whereas of_node_is_pcie()
prints the message based on the 'device_type' property of a pci_dev node.
You're right. Both warnings were getting reported for me, but for
different reasons.

I would be happy to just drop this patch and live with two warnings
in some cases (we should rarely see either one of them anyway, right?).

Is that OK with you? Does anyone feel this patch should be kept?
On my side, I have no problem to see two warnings and so, IHMO, this patch
can be dropped.

Unless I hear otherwise, that's what I will do, for v4, which
I'll send out sometime this week after addressing concerns
pointed out by Sashiko.

Thank you.

-Alex