Re: [PATCH 5/7] arm64: dts: qcom: pmk8850: Add ADC5 Gen4 peripheral

[Konrad Dybcio]

On 7/31/26 8:06 PM, Jishnu Prakash wrote:
> PMK8850 has an ADC5 Gen4 peripheral that acts as the master ADC for
> the platform, communicating with ADC peripherals on other PMICs on the
> system. Add the ADC peripheral node with PMK8850 die_temp and
> xo_therm channel nodes under it initially.
> 
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pmk8850.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmk8850.dtsi b/arch/arm64/boot/dts/qcom/pmk8850.dtsi
> index c7ba72fd48bc..44d1d1957f8a 100644
> --- a/arch/arm64/boot/dts/qcom/pmk8850.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8850.dtsi
> @@ -7,6 +7,7 @@
>  #include <dt-bindings/input/linux-event-codes.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/spmi/spmi.h>
> +#include "qcom-adc5-gen4.h"
>  
>  &spmi_bus0 {
>  	pmic@0 {
> @@ -45,6 +46,30 @@ pmk8850_gpios: gpio@b800 {
>  			#interrupt-cells = <2>;
>  		};
>  
> +		pmk8850_vadc: adc@9000 {
> +			compatible = "qcom,spmi-adc5-gen4";
> +			reg = <0x9000>, <0x9100>;

nit: one a line would be perfect

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad

P.S. can we also add some more channels that look like they would
be present on all 8850 installations, e.g. offset-ref, vref-1.25
etc.?

Konrad