Re: [PATCH RESEND v6 4/5] mfd: axp20x: Add support for AXP318W PMIC

[Chen-Yu Tsai]

On Thu, Sep 3, 2026 at 2:46 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>
> On dim. 23 août 2026 at 21:17, Chen-Yu Tsai <wens@xxxxxxxxxx> wrote:
>
> >>
> >> +enum axp318_irqs {
> >> +       AXP318_IRQ_DCDC1_V_LOW,
> >> +       AXP318_IRQ_DCDC2_V_LOW,
> >> +       AXP318_IRQ_DCDC3_V_LOW,
> >> +       AXP318_IRQ_DCDC4_V_LOW,
> >> +       AXP318_IRQ_DCDC5_V_LOW,
> >> +       AXP318_IRQ_DCDC6_V_LOW,
> >> +       AXP318_IRQ_DCDC7_V_LOW,
> >> +       AXP318_IRQ_DCDC8_V_LOW,
> >> +       AXP318_IRQ_DCDC9_V_LOW,
> >> +       AXP318_IRQ_DIE_TEMP_HIGH_LV1,
> >> +       AXP318_IRQ_DIE_TEMP_HIGH_LV2,
> >
> >> +       AXP318_IRQ_PEK_SHORT,
> >> +       AXP318_IRQ_PEK_LONG,
> >
> > The order of these two are reversed.
> >
> >> +       AXP318_IRQ_PEK_FAL_EDGE,
> >> +       AXP318_IRQ_PEK_RIS_EDGE,
> >
> > And these two as well.
>
> Applied everything except this is last one.
> AFAICT, the IRQ above are not inverted ... but it is slightly confusing
> because the regmap_irqs orders it the other way

I'm reading them in ascending bit order, so it should be DCDC1 ~ 9,
die temp high lv1, lv2, PEK long press, PEK short press, PEK falling
edge, PEK rising edge.

I guess I got confused somewhere reading the list backwards...

> Thanks for the detailed review
>
> >
> > Once all these are fixed,
> > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxxxx>
> >
> >
> > ChenYu
> >
> >> +       AXP318_IRQ_GPIO1_INPUT = 20,
> >> +       AXP318_IRQ_GPIO2_INPUT,
> >> +       AXP318_IRQ_GPIO3_INPUT,
> >> +       AXP318_IRQ_WDOG_EXPIRE = 24,
> >> +};
> >> +
> >>  enum axp717_irqs {
> >>         AXP717_IRQ_VBUS_FAULT,
> >>         AXP717_IRQ_VBUS_OVER_V,
> >>
> >> --
> >> 2.47.3
> >>
>
> --
> Jerome