[PATCH RFC v2 5/6] ASoC: cs35l36: Implement set_tdm_slot to program RX and TX slots

From: David Heidelberg via B4 Relay

Date: Thu Sep 03 2026 - 14:39:07 EST


From: David Heidelberg <david@xxxxxxx>

Program the ASP RX and TX slot registers from the TDM masks passed by
the machine driver. Each set bit in a mask names a slot; codec channels
are assigned to those slots in order, ASPRX1 taking the first RX slot
and ASPTX1..TX8 the first eight TX slots, with a warning if the mask
names more slots than the device has channels.

Passing slots == 0 or an empty mask restores the hardware defaults,
ASPRX1 in slot 0 and ASPTX1..TX8 in slots 0..7.

This lets a machine driver with several amplifiers on one bus, such as
sdm845 with two CS35L36, put each amplifier on its own RX slot and keep
their TX slots from colliding.

Assisted-by: Claude:claude-4.6-opus
Signed-off-by: David Heidelberg <david@xxxxxxx>
---
sound/soc/codecs/cs35l36.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
index 89645327945f1..4d35ca6291548 100644
--- a/sound/soc/codecs/cs35l36.c
+++ b/sound/soc/codecs/cs35l36.c
@@ -942,20 +942,64 @@ static const struct cs35l36_pll_config *cs35l36_get_clk_config(
for (i = 0; i < ARRAY_SIZE(cs35l36_pll_sysclk); i++) {
if (cs35l36_pll_sysclk[i].freq == freq)
return &cs35l36_pll_sysclk[i];
}

return NULL;
}

+static void cs35l36_mask_to_slots(struct cs35l36_private *cs35l36,
+ unsigned long mask, unsigned int base_reg,
+ unsigned int nchan)
+{
+ unsigned int chan = 0, shift;
+ int slot;
+
+ /* Two 6-bit slot fields per register, at bits 0 and 16 */
+ for_each_set_bit(slot, &mask, BITS_PER_TYPE(mask)) {
+ if (chan == nchan) {
+ dev_warn(cs35l36->dev,
+ "Too many slots in TDM mask: %lx\n", mask);
+ return;
+ }
+
+ shift = (chan % 2) * CS35L36_ASP_TX2_SLOT_SHIFT;
+ regmap_update_bits(cs35l36->regmap, base_reg + (chan / 2) * 4,
+ CS35L36_ASP_RX1_SLOT_MASK << shift,
+ slot << shift);
+ chan++;
+ }
+}
+
+static int cs35l36_set_tdm_slot(struct snd_soc_dai *dai,
+ unsigned int tx_mask, unsigned int rx_mask,
+ int slots, int slot_width)
+{
+ struct cs35l36_private *cs35l36 =
+ snd_soc_component_get_drvdata(dai->component);
+
+ /* Note: rx/tx is from point of view of the CPU end */
+ if (!slots || !rx_mask)
+ rx_mask = BIT(0); /* ASPRX1 in slot 0 */
+
+ if (!slots || !tx_mask)
+ tx_mask = GENMASK(7, 0); /* ASPTX1..8 in slots 0..7 */
+
+ cs35l36_mask_to_slots(cs35l36, rx_mask, CS35L36_ASP_RX1_SLOT, 1);
+ cs35l36_mask_to_slots(cs35l36, tx_mask, CS35L36_ASP_TX1_TX2_SLOT, 8);
+
+ return 0;
+}
+
static const struct snd_soc_dai_ops cs35l36_ops = {
.set_fmt = cs35l36_set_dai_fmt,
.hw_params = cs35l36_pcm_hw_params,
.set_sysclk = cs35l36_dai_set_sysclk,
+ .set_tdm_slot = cs35l36_set_tdm_slot,
};

#define CS35L36_RATES ( \
SNDRV_PCM_RATE_8000_48000 | \
SNDRV_PCM_RATE_12000 | \
SNDRV_PCM_RATE_24000 | \
SNDRV_PCM_RATE_88200 | \
SNDRV_PCM_RATE_96000 | \

--
2.55.0