Re: [PATCH] ARM: dts: BCM5301X: AC68U: set WAN MAC from nvram
From: Florian Fainelli
Date: Thu Sep 03 2026 - 16:07:13 EST
On 8/5/26 12:01, Rosen Penev wrote:
The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
userspace.
nvram size found from a random bootlog online.
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
You are doing two things here:
- assign the MAC address from NVRAM
- declare the switch ports along with their label
Please split this up in two separate patches, thank you.
Also, enabling port 5 is problematic, see this discussion:
https://lore.kernel.org/all/20260831085217.391-1-strst.gs@xxxxxxxxx/
This applies to all of the similar patches you submitted, therefore I won't repeat this feedback.
--
Florian