Re: [PATCH net-next v2] net: fec: Propagate PTP initialization errors

[Bui Duc Phuc]

>
> Is this a real bug that bothers people? or just an improvement?
> For real bug, I think the patch should target to net tree.
>

I consider this a real bug rather than just an improvement, for two reasons.

First, commit b86bcb299092 was a bug fix and was also backported to stable.
This patch fixes the error handling in that change, which incorrectly
treats errors
other than -ENXIO as an absent optional IRQ. Therefore, I believe this
fix is also
relevant to stable kernels.

Second, the current implementation can silently ignore -EPROBE_DEFER and
continue probing instead of deferring. On an affected platform, this
can result in
the PPS IRQ not being set up, causing the corresponding PPS functionality to be
unavailable to the user.

I don't have hardware to reproduce this specific case, so the issue
was found by
code inspection rather than a user report.
If you think this fix is appropriate for the net tree, I'm happy to
retarget and resend it there.

Best regards,
Phuc