Re: [PATCH] iio: chemical: add SGP41 driver

[Jonathan Cameron]

On Mon, 31 Aug 2026 23:21:57 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Mon, 31 Aug 2026 20:42:35 +0530
> Akshat Chandra <notmissinge@xxxxxxxxx> wrote:
> 
> > Signed-off-by: Akshat Chandra <notmissinge@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/trivial-devices.yaml  |   2 +
> >  drivers/iio/chemical/Kconfig                  |  11 +
> >  drivers/iio/chemical/Makefile                 |   1 +
> >  drivers/iio/chemical/sgp41.c                  | 384 ++++++++++++++++++
> >  4 files changed, 398 insertions(+)
> >  create mode 100644 drivers/iio/chemical/sgp41.c
> >   
> 
> Not only you're missing a commit message, you're also missing a
> MAINTAINERS entry and a dt-bindings entry! Please fix this!
> (Note, the dt-bindings and MAINTAINERS entry should go together
> in one patch, preferrably first in the series).
> 

Whilst it should be a separate patch, the route here to use
trivial-devices might make sense.  Only thing that might be
worth documenting would be vdd-supply.

I'm would be looking for description in the cover letter of how this
is different from, and not suited to extension of another drive
such as the sgp40 (obviously there are more channels on one than
the other so it isn't trivial!)

Jonathan