Re: [PATCH v13 1/4] clk: scmi: fix SSC spread conversion

[Peng Fan]

On Thu, Sep 03, 2026 at 05:32:13PM +0200, Dario Binacchi wrote:
>The spread_bp field of struct clk_spread_spectrum holds the modulation
>depth in permyriad (1/100 of a percent), as documented in
>clk-provider.h and in the assigned-clock-sscs binding, while the i.MX
>SCMI OEM extension expects a value in tenths of a percent, as pointed
>out by Peng Fan.
>
>The conversion divides spread_bp by 10000 instead of 10, as reported by
>Sashiko, so any valid configuration is truncated to 0 and the hardware
>is silently programmed with no spread at all.
>
>Divide by 10 and fix the comment accordingly.
>
>Fixes: 77369b1e6a37 ("clk: scmi: Add i.MX95 OEM extension support for SCMI clock driver")
>Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
>Closes: https://lore.kernel.org/r/20260901155657.6A5981F00A3A@xxxxxxxxxxxxxxx
>Reported-by: Peng Fan <peng.fan@xxxxxxx>
>Closes: https://lore.kernel.org/r/ZR6PR04MB375776A27E98F140534E8F7FE488B62@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
>

Reviewed-by: Peng Fan <peng.fan@xxxxxxx>