Re: [PATCH v4 3/5] phy: qualcomm: qmp-combo: Add preliminary USB4 support

[Konrad Dybcio]

On 9/1/26 2:44 PM, Manivannan Sadhasivam wrote:
> On Thu, Aug 20, 2026 at 04:24:12PM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> Some Combo PHYs (so far only on SC8280XP, X1E80100 and Glymur), come in
>> a flavor called USB43DP, which as the name implies, features USB4, USB3
>> and DP signal processing capabilities. In that architecture, USB3 and
>> USB4 PHYs share the same USB_PLL while featuring separate logic spaces.
>> The DP part is roughly the same as on the instances without USB4.

[...]

>> +	case QMPPHY_MODE_USB4:
>> +		writel(USB4_MODE, com + QPHY_V3_DP_COM_PHY_MODE_CTRL);
>> +
>> +		/* bring both QMP USB and QMP DP PHYs PCS block out of reset */
>> +		/* TODO: disable DP PLL if there are no active tunnels after router setup */
> 
> 100 column width generally applies to code, not comments. Comments should still
> be wrapped to 80 columns.

I believe this isn't a real concern.. checkpatch certainly doesn't care:

# LONG_LINE_COMMENT     a comment starts before but extends beyond $max_line_length
# LONG_LINE_STRING      a string starts before but extends beyond $max_line_length
# LONG_LINE             all other lines longer than $max_line_length

(all take the same value, preset to 100 at the top of the file)

Konrad