Re: [PATCH v2 0/3] soundwire: bus: re-enable CLOCK_STOP_MODE1 support

[Pierre-Louis Bossart]

On 9/1/26 05:03, Bard Liao wrote:
> Add CLOCK_STOP_MODE1 back to allow the peripheral to utilize it when
> the clock is stopped.
> This mode is designed for power-sensitive devices as it enables a deeper
> power-saving state, although it does not retain the peripheral's state
> during the clock stop.
> 
> v2:
>  - check slave->probed before looking at the driver to avoid NULL pointer
>    dereference.
>  - add wake_enable parameter to stop_bus ops to stop the clock but keep the
>    bus unwakeable during system suspend.
> 
> Bard Liao (3):
>   soundwire: bus: add CLOCK_STOP_MODE1 support back
>   soundwire: Intel: add wake_enable parameter to stop_bus ops
>   soundwire: Intel: stop sdw clock in system suspend
> 
>  drivers/soundwire/bus.c              | 54 +++++++++++++++++-----------
>  drivers/soundwire/intel.h            |  6 ++--
>  drivers/soundwire/intel_auxdevice.c  |  7 ++--
>  drivers/soundwire/intel_bus_common.c |  8 ++---
>  include/linux/soundwire/sdw.h        |  4 +++
>  include/linux/soundwire/sdw_intel.h  |  2 +-
>  6 files changed, 50 insertions(+), 31 deletions(-)
> 

Thanks Bard, LGTM - this addresses my previous feedback.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>