Re: [PATCH v2 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver

From: Konrad Dybcio

Date: Fri Sep 04 2026 - 06:19:03 EST




On 02-Sep-26 18:11, Muzaffer Kadir wrote:
> Hi Konrad,

[...]

>> must have a matching mipi_dsi0 entry in the GPIO0 PINGROUP() definition. The same consistency is required for every item in the table. The gpio function is intentionally excluded because it is inserted
>> implicitly by the PINGROUP() macro.
>
> Sibling SoCs like msm8917, msm8953 and
> msm8976 do leave them without any PINGROUP() too.
> I don't know what function index they map to
> and I don't want to cause bugs by wrong indexes.
> I don't know what to do with them.
> Should I remove them?

Apparently, for 8952, someone took their creative liberty
to rename function 0 (GPIO) into what looks like the
assignments on some internal devboard. All of these are
just GPIO functions (i.e. drop the other definitions,
they're totally bogus) except for:

Function GPIO group Mux index
━━━━━━━━━━━━━━━━━━━━━━ ━━━━━━━━━━━━ ━━━━━━━━━━━
qdss_cti_trig_out_b0 GPIO2 12
────────────────────── ──────────── ───────────
qdss_cti_trig_out_a1 GPIO3 11

Thanks for spotting this

Konrad