Re: [PATCH v2 0/5] iio: adc: bcm_iproc_adc: use device-managed resources
From: Marcelo Schmitt
Date: Fri Sep 04 2026 - 18:30:18 EST
Hello Shahid,
On 09/01, mdshahid03@xxxxxxxxx wrote:
> Hi all,
>
> Thanks for the reviews and suggestions.
>
> For v3, I will incorporate the following changes:
>
> Patch 2/5:
> -Add the direct includes for <linux/bits.h>, <linux/types.h>, and <linux/array_size.h>.
> Keep <linux/device-id/of.h> and <linux/iio/types.h> out, as these are already provided through the appropriate headers.
> Patch 5/5:
> -Remove the now-unnecessary platform_set_drvdata().
> -Return devm_iio_device_register() directly.
> -Remove the unnecessary backticks around function names in the commit message.
>
> For patch 3/5, I understand that splitting the ADC cleanup into a follow-up patch would be preferable from a patch-scope
> perspective.I will split this into a separate patch for v3.
>
> Please let me know if I have misunderstood any of the review comments.
I believe the above list is correct.
With best regards,
Marcelo