Re: [PATCH v1] ACPI: glue: Reduce debug noise from acpi_device_notify()

From: Andy Shevchenko

Date: Sat Sep 05 2026 - 02:57:08 EST


On Fri, Sep 04, 2026 at 02:55:03PM +0200, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
>
> When debug is enabled in the ACPI glue code that handles binding
> devices to ACPI companions, acpi_device_notify() produces a lot of
> message noise related to devices that have no ACPI companions.
>
> Reduce that noise by checking the most obvious cases, ACPI device
> objects and devices without a bus type, directly and returning from
> acpi_device_notify() in these cases without printing any debug
> messages.
>
> Also make the debug messages that get printed more informative and
> change the format prefix to "ACPI/glue", so it is easier to filter
> these messages.

I would argue that the consistent formatting will be "ACPI: glue: "

$ git grep -n 'pr_fmt.*ACPI: [^"]' -- drivers/acpi/ | wc -l
24

The / is used only in two cases: acpi/hmat and acpi/mrrm.

--
With Best Regards,
Andy Shevchenko