Re: [PATCH net-next v5 3/6] net: dsa: motorcomm: relocate MIB polling initialization to dsa_setup()

[Kyle Switch]

On 9/4/26 21:48, Andrew Lunn wrote:
> On Fri, Sep 04, 2026 at 05:54:13PM +0800, Kyle Switch wrote:
> > Move MIB polling start from probe() to dsa_setup()
> Actually, having thread the following patches...
>
> For every start, there is generally a stop.
>
> You move start from probe() to dsa_setup().
>
> Should you not move stop from remove() to dsa_teardown()?
> You want to keep the driver symmetrical.

Ans, yes, in the next version, we will optimize the handling

of MIB polling enable by moving into setup(), and remove MIB

polling disable into teardown(). From the current perspective, the

mib_init flag is no longer needed.

> 	Andrew