Re: [PATCH v3 06/14] gpu: nova-core: add the GIN interrupt tree and allocate its vectors

[Alexandre Courbot]

On Mon Sep 7, 2026 at 8:10 AM JST, John Hubbard wrote:
> On 9/5/26 6:55 AM, Alexandre Courbot wrote:
>> On Thu Sep 3, 2026 at 12:15 PM JST, John Hubbard wrote:
>> <...>
>>> +impl SubtreeVectors<'_> {
>>> +    /// Returns the interrupt type these vectors were allocated as.
>>> +    pub(crate) fn msi_type(&self) -> MsiType {
>>> +        self.msi_type
>>> +    }
>> 
>> This method is not needed. It is only used by sub-modules, which can
>> access the private `msi_type` directly.
>> 
>
> Hi Alex,
>
> Thanks for all these reviews! In addition to applying fixes for each item,
> I'm also doing the following for the upcoming v4 spin:
>
> a) Rebasing onto Gary's IO projections, and taking full advantage of them.
>
> b) Fixing up all comment prose.
>
> c) Using a type system instead of returning a bare u32 for some of the
> interrupt status reading and clearing.
>
> I'm keeping it up to date, including testing, so it's ready whenever
> you get tired of looking at v3. :)

Still on it, and I'll send some more comments for v3 today. Let's
include them before respinning.

Thanks!