Re: [PATCH] dt-bindings: usb: Add ITE IT5271/IT5272/IT5273/IT5274 support

[Krzysztof Kozlowski]

On Thu, Sep 03, 2026 at 06:15:43PM +0800, Amber Kao wrote:
> Add device tree binding documentation for the ITE IT527x series
> (IT5271, IT5272, IT5273, and IT5274) I2C-based USB Type-C Power
> Delivery (PD) controllers.
> 
> The series comprises four variants differing by port count and
> Power Range support:
> - IT5271: single-port, SPR (Standard Power Range)
> - IT5272: two-port, SPR
> - IT5273: single-port, EPR (Extended Power Range)
> - IT5274: two-port, EPR
> 
> Signed-off-by: Amber Kao <ite_pd@xxxxxxxxxx>
> ---
> The driver for this device family is shared with ITE IT8851/IT8853,
> currently under review as a separate series:
> https://patchwork.kernel.org/project/linux-usb/patch/20260807-ucsi-itepd-v7-2-998ac11ed0ef@xxxxxxxxxx/
> 
> This binding is submitted independently so it can be reviewed on

No, it cannot be reviewed on its own, because splitting it means you
have undocumented compatibles in the other patchset.

And if you do not, then there is no user for this binding.


> its own; once the driver series lands, IT527x support will be
> wired into it there.

Then what is the point of this binding now?

> ---
>  .../devicetree/bindings/usb/ite,it5271.yaml        | 176 +++++++++++++++++++++
>  MAINTAINERS                                        |   8 +
>  2 files changed, 184 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ite,it5271.yaml b/Documentation/devicetree/bindings/usb/ite,it5271.yaml
> new file mode 100644
> index 000000000000..29cd7add9bde
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ite,it5271.yaml
> @@ -0,0 +1,176 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ite,it5271.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ITE IT5271/IT5272/IT5273/IT5274 USB Type-C Power Delivery Controller
> +
> +maintainers:
> +  - Amber Kao <amber.kao@xxxxxxxxxx>
> +
> +description: |
> +  The ITE IT527x series are I2C-based USB Type-C Power Delivery (PD)
> +  controllers.
> +  All variants support DFP/UFP/DRP roles, USB PD 3.1, Fast Role Swap,
> +  USB4, and TBT3/TBT4 alternate modes.
> +
> +  The series comprises four ordering part numbers built on identical
> +  silicon; port count and PD power range support are configured via
> +  firmware/OTP rather than differing in the register interface itself:
> +    - IT5271: single-port variant, SPR
> +    - IT5272: two-port variant, SPR
> +    - IT5273: single-port variant, EPR
> +    - IT5274: two-port variant, EPR
> +

Why isn't this entire binding part of the other file?

> +properties:
> +  compatible:
> +    oneOf:
> +      - const: ite,it5271
> +      - items:
> +          - const: ite,it5272

enum

I finished actually here, becausr I still find reviewing outside of
driver a waste of our time.

Best regards,
Krzysztof