Re: [PATCH] mm/huge_memory: bypass THP tuneables for huge pfnmap mappings

[Lorenzo Stoakes (ARM)]

On Mon, Sep 07, 2026 at 06:08:31PM +0200, David Hildenbrand (Arm) wrote:
>
> >> 1. is vma_allow_thp_tuneables_file() better? Then all three helpers are
> >> vma + a verb + thp_tuneables_file().
> >
> > That's a good idea! Much better thanks.
> >
> >>
> >> 2. is vma_file_ a better prefix than putting file at the end?
> >
> > Yeah, it's an annoying one as kinda want to say 'file-backed VMA' but I think
> > you're right vma_xxx_file() -> vma_file_xxx() is better.
> >
> > Andrew - could you fix that up in place?
> >
> > Obviously if there's further feedback I can respin as well.
>
> Just as a general note I really hate these in-place updates.
>
> For a reviewer perspective (like me stumbling over this) this is just a mess.
>
> Resending with b4 is as easy as it gets.

Ack, you are right to be honest, and I do empathise obviously.

I will respin these in future!

Let me know if you want me to respin this to make life a bit easier?

>
> --
> Cheers,
>
> David

--
Cheers, Lorenzo