Re: [PATCH 1/2] net: usb: cdc_ether: add NCSI passthrough support

[Andrew Lunn]

> +/* NCSI operates at 100 Mbps */
> +#define NCSI_SPEED_BPS		(100 * 1000000)

Why 100Mbps? RGMII is often used, running at 1G.

> +struct cdc_ncsi_priv {
> +	struct ncsi_dev *ndev;
> +	struct net_device_ops netdev_ops;
> +	const struct net_device_ops *orig_netdev_ops;
> +};
> +
> +static int cdc_ncsi_open(struct net_device *net);
> +static int cdc_ncsi_stop(struct net_device *net);

No forward declarations. Move the code around so they are not needed.

   Andrew