Re: [PATCH v6 00/11] media: rcar: Streams support

[Niklas Söderlund]

Hi Tomi,

Thanks for your work.

On 2026-06-17 14:54:53 +0300, Tomi Valkeinen wrote:
> Add streams support to Renesas rcar platform driver.
> 
> The series keeps compatibility with the current upstream for a single
> stream use case. However, in upstream there's a limited custom
> multi-stream support implemented to the rcar driver, which will be
> replaced with the upstream's Streams API.
> 
> I have tested this series on Sparrow-Hawk board, with a few different
> setups:
> 
> 1) IMX219 on the CSI0 connector (video)
> 
> 2) Arducam FPD-Link board + 4 x IMX219 on the CSI0 connector (video)
>   - Only two extra patches needed for testing: one to enable the V4L2
>     Streams API, another to add .get_frame_desc() to imx219.

Out of curiosity, is the IMX219 patch posted somewhere?

> 
> 3) IMX219 on the CSI0 connector (video + emb)
> - A bunch of other patches applied to enable full streams support,
>   internal pads and embedded data support in imx219 and v4l2 framework
>  
> 4) Arducam FPD-Link board + 4 x IMX219 on the CSI0 connector (video + emb)
> - A bunch of other patches applied to enable full streams support,
>   internal pads and embedded data support in imx219 and v4l2 framework
> - Tested with video and embedded data streams from all four cameras (so
>   8 streams in total)
> 
> I can't properly test the error recovery, but I did trigger it manually
> with the FPD-Link setup running, and it worked fine.
> 
> I have observed one issue with the embedded data (i.e. a test case not
> supported in upstream kernel): when stopping streaming, VIN says that it
> cannot stop the stream. I haven't debugged that, but a possible issue is
> that if the video stream for the imx219 is stopped first, the embedded
> data stops also, and VIN does not get the frame-end it is waiting for.
> 
> This needs further study, but I don't see it as a blocker for this
> series as embedded data support is not in upstream.
> 
>  Tomi
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>

For single stream use-cases (as before this change), for the whole 
series.

Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
> Changes in v6:
> - Rebase on v7.1, dropping the need for any dependency patches
> - New patch "media: rcar-vin: Fix comment related to stride handling"
> - Add comment wrt. not allowing get_frame_desc on rcar-csi2 for gen3
> - Fix rcar-csi2 error recovery. In the previous version it just disabled
>   and enabled the CSI2 RX, now it also disables and enables the streams
>   on the source device.
> - As part of the previous change, we now track enabled_sink_streams_mask
>   in rcar-csi2 instead of stream_count (the previous code also wasn't
>   quite right, as it assumed enable/disable streams ops would only be
>   called with a single stream. which is true, but was a hidden
>   assumption).
> - Fix issue in rcar-csi2, v4l2_subdev_state_xlate_streams() was always
>   called with RCAR_CSI2_SOURCE_VC0, instead of the actual source_pad.
> - Link to v5: https://lore.kernel.org/r/20260311-rcar-streams-v5-0-3e6c957d7567@xxxxxxxxxxxxxxxx
> 
> Changes in v5:
> - Rebase on v7.0-rc2, with the streams preparation series and
>   get_frame_desc_passthrough series as dependencies
> - This series is now smaller, as the non-streams parts are in the
>   streams preparation series
> - Fix "variable ‘format’ set but not used" warning
> - Link to v4: https://lore.kernel.org/r/20251216-rcar-streams-v4-0-f28b4831cc67@xxxxxxxxxxxxxxxx
> 
> Changes in v4:
> - Rebased on v6.18, with minor conflicts resolved
> - Improved patch descriptions
> - Re-ordered the patches a bit to move changes that could be applied
>   without the full streams support to the beginning of the series
> - Added "media: rcar-vin: Link VINs on Gen3 to a single channel on each
>   CSI-2" which removes possibility of wrong routing config on Gen3
> - Added "media: rcar-csi2: Improve FLD_FLD_EN macros" which was part of
>   another patch in v3
> - Addressed minor comments (constifyings, cosmetics)
> - Fixed the missing stream_count checks in disable_streams ops
> - Fixed a few instances in csisp and csi2 where
>   v4l2_subdev_state_get_format() was called with hardcoded pad/stream,
>   instead of using the data from the route
> - Dropped unnecessary ISPPROCMODE_DT_REG register clears
> - Squashed "media: rcar-csi2: Add more stream support to
>   rcsi2_calc_mbps()" into a previous patch
> - Dropped wrong use_isp check from csi2's rcsi2_set_routing()
> - Link to v3: https://lore.kernel.org/r/20250530-rcar-streams-v3-0-026655df7138@xxxxxxxxxxxxxxxx
> 
> Changes in v3:
> - Rebased on top of latest linux-media
> - Dropped dependencies which are already in linux-media (only remaining
>   dependency is v4l2_subdev_get_frame_desc_passthrough)
> - Tested on white-hawk board, using the staging deser TPG
> - Also tested in a WIP branch for GMSL2 (two video streams)
> - Link to v2: https://lore.kernel.org/r/20250326-rcar-streams-v2-0-d0d7002c641f@xxxxxxxxxxxxxxxx
> 
> Changes in v2:
> - Rebased on top of latest upstream, and updated the dependencies to
>   match the latest serieses sent.
> - Add new patch "media: rcar-csi2: Use the pad version of v4l2_get_link_freq()"
> - Drop "media: rcar-csi2: Fix typo" (it was not a typo)
> - Update the code in calc_mbps(). The previous method relied on
>   V4L2_CID_LINK_FREQ, but that's not available if the link-freq is
>   provided via get_mbus_config().
> - Dropped dependencies to Niklas' old series which doesn't apply
>   cleanly. It's needed for multi-stream, but not for the current
>   upstream which only has a single stream use case.
> - Link to v1: https://lore.kernel.org/r/20250219-rcar-streams-v1-0-f1b93e370aab@xxxxxxxxxxxxxxxx
> 
> ---
> Tomi Valkeinen (11):
>       media: rcar-vin: Fix comment related to stride handling
>       media: rcar-vin: Link VINs on Gen3 to a single channel on each CSI-2
>       media: rcar-isp: Move {enable|disable}_streams() calls
>       media: rcar-csi2: Move {enable|disable}_streams() calls
>       media: rcar-csi2: Switch to Streams API
>       media: rcar-isp: Switch to Streams API
>       media: rcar-csi2: Add .get_frame_desc op
>       media: rcar-isp: Call get_frame_desc to find out VC & DT
>       media: rcar-csi2: Call get_frame_desc to find out VC & DT (Gen3)
>       media: rcar-csi2: Add full streams support
>       media: rcar-isp: Add full streams support
> 
>  drivers/media/platform/renesas/rcar-csi2.c         | 373 ++++++++++++++++-----
>  drivers/media/platform/renesas/rcar-isp/csisp.c    | 227 ++++++++++---
>  .../media/platform/renesas/rcar-vin/rcar-core.c    |  27 +-
>  drivers/media/platform/renesas/rcar-vin/rcar-dma.c |   2 +-
>  4 files changed, 487 insertions(+), 142 deletions(-)
> ---
> base-commit: 8cd9520d35a6c38db6567e97dd93b1f11f185dc6
> change-id: 20250219-rcar-streams-1fdea8860e5e
> 
> Best regards,
> --  
> Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> 

-- 
Kind Regards,
Niklas Söderlund