Re: [PATCH net] selftests/drivers/net: include lib/sh/*.sh

[Hangbin Liu]

On Tue, Sep 08, 2026 at 07:29:16AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> - [Medium] Incomplete fix:
>   `tools/testing/selftests/drivers/net/netdevsim/Makefile` is the only…
> 
> --
> 
> selftests/drivers/net: include lib/sh/*.sh
> 
> This adds $(wildcard ../../net/lib/sh/*.sh) to TEST_INCLUDES in the
> drivers/net selftest Makefiles so that net/lib/sh/defer.sh gets installed
> by "make install", and sorts the TEST_INCLUDES lists while at it.
> 
> > diff --git a/tools/testing/selftests/drivers/net/Makefile b/tools/testing/selftests/drivers/net/Makefile
> > index d5bf4cb638a8c..ab39c2e508f0a 100644
> > --- a/tools/testing/selftests/drivers/net/Makefile
> > +++ b/tools/testing/selftests/drivers/net/Makefile
> > @@ -3,6 +3,7 @@ CFLAGS += $(KHDR_INCLUDES)
> >  
> >  TEST_INCLUDES := $(wildcard lib/py/*.py) \
> >  		 $(wildcard lib/sh/*.sh) \
> > +		 $(wildcard ../../net/lib/sh/*.sh) \
> >  		 ../../net/lib.sh \
> >  
> >  TEST_GEN_FILES := \
> 
> [Severity: Medium]
> Was drivers/net/netdevsim intentionally left out?  It is the only Makefile
> under tools/testing/selftests/drivers/net/ that this patch does not touch,
> and it defines no TEST_INCLUDES at all:
> 
> tools/testing/selftests/drivers/net/netdevsim/Makefile:
> 	TEST_PROGS := \
> 		devlink.sh \
> 		...
> 		peer.sh \
> 		...
> 	# end of TEST_PROGS
> 
> 	TEST_FILES := \
> 		ethtool-common.sh
> 	# end of TEST_FILES
> 
> 	include ../../../lib.mk

Yes, netdevsim doesn't have TEST_INCLUDES at all. I think it deserves
its own separate patch.

Thanks
Hangbin