[PATCH] firewire: core: fix type of transaction data in config ROM parser test
From: Takashi Sakamoto
Date: Tue Sep 08 2026 - 08:35:18 EST
The type of transaction data should be __be32 in the stub function for the
asynchronous transactions.
Fixes: 23e0d2e849eb ("firewire: core: add test to detect irm-is-1394-1995-only quirk in config ROM parser")
Fixes: f8e5070bf292 ("firewire: core: add test to avoid excessive configuration ROM length")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202609060257.8wQo9w9N-lkp@xxxxxxxxx/
Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
---
drivers/firewire/config-rom-parser-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firewire/config-rom-parser-test.c b/drivers/firewire/config-rom-parser-test.c
index e5c173353057..45f1ead326c5 100644
--- a/drivers/firewire/config-rom-parser-test.c
+++ b/drivers/firewire/config-rom-parser-test.c
@@ -206,7 +206,7 @@ static int stub_run_transaction_regular(struct fw_card *card, int tcode, int des
KUNIT_ASSERT_EQ(test, length, 4);
unsigned int index = (offset - (CSR_REGISTER_BASE | CSR_CONFIG_ROM)) / sizeof(u32);
- u32 *quadlet = payload;
+ __be32 *quadlet = payload;
KUNIT_EXPECT_LE(test, speed, param->expected_speed);
KUNIT_EXPECT_LT(test, index, param->quadlet_length);
@@ -264,7 +264,7 @@ static int stub_run_transaction_malformed(struct fw_card *card, int tcode, int d
KUNIT_ASSERT_EQ(test, length, 4);
unsigned int index = (offset - (CSR_REGISTER_BASE | CSR_CONFIG_ROM)) / sizeof(u32);
- u32 *quadlet = payload;
+ __be32 *quadlet = payload;
if (index < ARRAY_SIZE(config_rom_first_part))
*quadlet = cpu_to_be32(config_rom_first_part[index]);
--
2.53.0