Re: [PATCH 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line()

[Reinette Chatre]

Hi Ben,

On 9/7/26 2:21 AM, Ben Horgan wrote:
> Hi Reinette,
> 
> On 03/09/2026 17:57, Reinette Chatre wrote:
>> resctrl_io_alloc_parse_line() only has one caller that determines the
>> resource via resctrl_schema::res and then passes a pointer to the resource
>> as well as struct resctrl_schema.
>>
>> Only pass pointer to struct resctrl_schema. resctrl_io_alloc_parse_line()
>> can determine the resource itself.
> 
> Nit: Without taking into account that a resource is going to support multiple controls in the future
> this change feels a little under justified. Perhaps any extra line in the commit message is warranted.

I agree. I did have such snippet in an earlier attempt and our internal AI review suggested
it be dropped since it references work that is not included in this series self. 
I'll rework that snippet to see if I can find some middle ground.

> 
> Regardless, this looks good to me.
> 
> Reviewed-by: Ben Horgan <ben.horgan@xxxxxxx>

Thank you very much for this and the other reviews.

Reinette