RE: [PATCH V1 1/3] mshv: Rename memory deposit memory functions to _old
From: Michael Kelley
Date: Tue Sep 08 2026 - 17:36:29 EST
From: Mukesh R <mrathor@xxxxxxxxxxxxxxxxxxx> Sent: Tuesday, September 8, 2026 1:43 PM
>
> On 9/8/26 11:01, Michael Kelley wrote:
> > From: Mukesh R <mrathor@xxxxxxxxxxxxxxxxxxx> Sent: Monday, September 7, 2026 7:14 PM
[snip]
> >> -int hv_deposit_memory_node(int node, u64 partition_id,
> >> - u64 hv_status)
> >> +static int __maybe_unused hv_deposit_memory_node_old(int node, u64 partition_id, u64 hv_status)
> >
> > I'm not clear on why there is "__maybe_unused" here. If CONFIG_MSHV_ROOT
> > isn't defined, this whole file isn't built.
>
> The main 2nd patch adds newer version of the function, so this _old is
> not called anymore, and will generate compiler warning.
>
> Thanks,
> -Mukesh
>
OK, right. That makes sense.
Thx,
Michael