Re: [PATCH net v3 2/2] net: fec: free the PPS interrupt before tearing down the PHC and netdev

From: Bui Duc Phuc

Date: Wed Sep 09 2026 - 02:22:31 EST


> +
> + if (fep->pps_irq >= 0) {
> + free_irq(fep->pps_irq, ndev);
> + fep->pps_irq = -1;
> + }
> +

I think fep->pps_irq > 0 would be more appropriate here,
since the IRQ returned by platform_get_irq_byname_optional() or
platform_get_irq_optional() cannot be 0.