Re: [PATCH v5 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
From: Harendra Gautam
Date: Wed Sep 09 2026 - 02:27:39 EST
On Wed, Sep 9, 2026 at 1:19 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, Sep 07, 2026 at 05:39:26PM +0530, Harendra Gautam wrote:
> > Add the Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI
> > controller used on the Shikra audio platform, together with a dt-bindings
> > header for QAIF DAI and AIF interface IDs.
>
> > + clocks:
> > + minItems: 5
> > + maxItems: 9
> > +
> > + clock-names:
> > + description:
> > + The first five clocks are always required. Any further entries are the
> > + per-AIF bit clocks (aif_if<N>_ibit), supplied in order starting from
> > + AIF interface 0 for as many serial AIF interfaces as the board uses.
> > + minItems: 5
> > + items:
> > + - const: lpass_config
> > + - const: lpass_core_axim
> > + - const: aud_dma
> > + - const: aud_dma_mem
> > + - const: bus
> > + - const: aif_if0_ibit
> > + - const: aif_if1_ibit
> > + - const: aif_if2_ibit
> > + - const: aif_if3_ibit
>
> The driver doesn't request any of these clocks as optional, are they
> really optional? Probably easier to make them all mandatory and then
> relax later if they can genuinely be optional.
Thanks for your input. Will make all these clocks mandatory in the next version.
-Harendra