RE: [EXT] Re: [PATCH v18 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

[Lakshay Piplani]

> > +description: |
> > +  P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) is a family of multiport
> > +I3C
> > +  hub devices that connect to:-
> > +  1. A host CPU via I3C/I2C/SMBus bus on upstream side and connect to
> multiple
> > +     peripheral devices on the downstream  side.
> > +  2. Have two Controller Ports which can support either
> > +     I2C/SMBus or I3C buses and connect to a CPU, BMC or SOC.
> > +  3. P3H2840/ P3H2841 are 8 port I3C hub with eight Target Ports.
> > +  4. P3H2440/ P3H2441 are 4 port I3C hub with four Target Ports.
> > +     Target ports can be configured as SMBus or I3C and connect to
> > +     peripherals.
> > +
> > +  All variants use the same register interface. Software reads the
> > + number  of target ports from DEV_CAPAB. The x0/x1 variants differ in
> > + their  power-up defaults, which the driver replaces with the DT
> configuration.
>
> I don't understand what this driver reference means and what is its purpose
> here.

Okay, I will update the description accordingly to only convey the hardware details.

>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nxp,p3h2440
> > +      - nxp,p3h2441
> > +      - nxp,p3h2840
> > +      - nxp,p3h2841
>
> I don't see improvements.
>

For this one, could you let me know in a little bit more detail what you have in mind?

Best Regards
Lakshay

NXP Public