Re: [PATCH 6/7] arm64: dts: qcom: glymur: Add ADC support for Glymur CRD

[Jishnu Prakash]

Hi Konrad,

On 9/3/2026 2:19 PM, Konrad Dybcio wrote:
> On 7/31/26 8:06 PM, Jishnu Prakash wrote:
>> Add the ADC channels under the PMK8850 ADC node for the
>> other PMICS on the board with ADC peripherals. This includes
>> die temperature and VPH power channels per PMIC.
> 
> [...]
> 
>> +	thermal-zones {
>> +		sys-0-thermal {
> 
> Please name it xo-therm or something similar to make the connection
> more obvious

Sure, I'll update the node name to "xo-thermal" and make similar changes
in the other patch too.

> 
> [...]
> 
>> +&pmcx0102_c_e0_temp_alarm {
>> +	io-channels = <&pmk8850_vadc ADC5_GEN4_DIE_TEMP(0, 2)>;
>> +	io-channel-names = "thermal";
>> +};
>> +
>> +&pmcx0102_c_e1_temp_alarm {
>> +	io-channels = <&pmk8850_vadc ADC5_GEN4_DIE_TEMP(1, 2)>;
>> +	io-channel-names = "thermal";
>> +};
>> +
>> +&pmcx0102_d_e0_temp_alarm {
>> +	io-channels = <&pmk8850_vadc ADC5_GEN4_DIE_TEMP(0, 3)>;
>> +	io-channel-names = "thermal";
>> +};
>> +
>> +&pmcx0102_d_e1_temp_alarm {
>> +	io-channels = <&pmk8850_vadc ADC5_GEN4_DIE_TEMP(1, 3)>;
>> +	io-channel-names = "thermal";
>> +};
> 
> Are these going to be always wired up this way on all Glymur boards?

I'm not sure what you mean here - each temp-alarm peripheral here
is using the die_temp channel from the ADC on the same PMIC to
read the PMIC die temperature. Die_temp is an internal sensor
and the die_temp ADC channel is always present on any PMIC
which has ADC, it is not like thermistors which are optionally
connected to AMUX/GPIO pins and can change between boards, so
I think we can consider the above configuration will not change
between Glymur boards.

Does this answer your question?

Checking some more, I noticed that this file (glymur-crd.dtsi) is
included in one other board file (mahua-crd.dts) and that board
lacks a few PMICs used on Glymur, so I'll also make sure to
delete any Glymur ADC channels absent for that board.

Thanks,
JIshnu

> 
> Konrad