Re: [PATCH v2 1/2] firmware: arm_scmi: Protect xfer->async_done with xfer->lock

From: Cristian Marussi

Date: Wed Sep 09 2026 - 07:41:13 EST


On Wed, Sep 09, 2026 at 04:32:27AM +0000, Roland Dreier via B4 Relay wrote:
> From: Roland Dreier <rolanddreier@xxxxxxxxxx>
>
> Asynchronous SCMI commands are completed by a delayed response. The RX
> path signals the response with complete(xfer->async_done). Unlike
> xfer->done, xfer->async_done is a pointer to a completion owned by
> whoever is waiting for the delayed response, and it stays valid only for
> as long as that waiter is still waiting. In do_xfer_with_response() it
> is a DECLARE_COMPLETION_ONSTACK() in the caller's stack frame.
>

Hi,

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
Tested-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Thanks,
Cristian