Re: [PATCH] staging: rtl8723bs: align AES function parameters with open parenthesis

[Dan Carpenter]

On Sat, Sep 05, 2026 at 04:20:33PM +0900, JunHyeok Seo wrote:
> Align the continuation lines of the aes_cipher()
> parameter lists with their opening parenthesis,
> and replace the stray tab between the uint type
> and the hdrlen argument with a single space.

This paragraph should be wrapped at 72 characters.

> 
> This addresses the "Alignment should match open parenthesis" check
> reported by checkpatch.pl --strict.
> 
> No functional change.
> 
> Signed-off-by: JunHyeok Seo <starlights2283@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 2217cffac5f2..3de102a27517 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -765,8 +765,8 @@ static void construct_ctr_preload(u8 *ctr_preload,
>  	ctr_preload[15] = (unsigned char)(c % 256);
>  }
>  
> -static signed int aes_cipher(u8 *key, uint	hdrlen,
> -			u8 *pframe, uint plen)
> +static signed int aes_cipher(u8 *key, uint hdrlen,
> +			     u8 *pframe, uint plen)

Unless it's specified by the protocol spec, then "signed int" is
nonsense.  Plus the caller doesn't check so it might as well be
void.

regards,
dan carpenter