Re: [PATCH 01/23] scripts/mksysmap: drop the MODULE_INFO() symbols from kallsyms

[Lorenzo Stoakes (ARM)]

On Wed, Sep 09, 2026 at 09:47:18PM +0200, Nicolas Schier wrote:
> > Commit 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped")
> > keeps .modinfo symbols out of System.map and kallsyms, which assumes unique
> > IDs have a format like '__UNIQUE_ID_modinfo123'.
> >
> > However, commit afb026b6d35c ("compiler: Tweak __UNIQUE_ID() naming"), sent
> > in the same cycle, changes this to '__UNIQUE_ID_modinfo_123'.
> >
> > As a result this regexp has never matched and every kernel since v6.18 has
> > carried one kallsyms entries for every MODULE_INFO() declaration in the
> > kernel whether the modules are compiled or not.
> >
> > That's 5,810 entries for an x86 defconfig build and 15,200 for arm64.
> >
> > On x86 defconfig that is 113 KiB of kallsyms tables and 32 KiB of bzImage,
> > and every lookup walks past them.
> >
> > Fix the pattern.
> >
> > Fixes: 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped")
> >
> > No measurable change in build time, the smaller tables are not on any path
> > the build waits for.
> >
>
> For consistency, it would be nice to have the 'Fixes:' trailer at the
> beginning of the trailer block (that is: here.)

Yeah sorry my screw up when rejigging the commit message :)

>
> > Assisted-by: LLM
> > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> >
> > diff --git a/scripts/mksysmap b/scripts/mksysmap
> > index c4531eacde20..56a8b8bbdb37 100755
> > --- a/scripts/mksysmap
> > +++ b/scripts/mksysmap
> > @@ -83,7 +83,7 @@
> >  / _SDA2_BASE_$/d
> >
> >  # MODULE_INFO()
> > -/ __UNIQUE_ID_modinfo[0-9]*$/d
> > +/ __UNIQUE_ID_modinfo_[0-9]*$/d
> >
> >  # ---------------------------------------------------------------------------
> >  # Ignored patterns
>
> Thanks!
>
> Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

Thanks!

>
> --
> Nicolas
>

--
Cheers, Lorenzo