Re: [PATCH] selftests: ublk: install test_common.sh and trace/ scripts

[Ming Lei]

On Wed, Sep 9, 2026 at 8:26 AM Mahmoud Nagy Adam <mngyadam@xxxxxxxxx> wrote:
>
> Every ublk test script sources test_common.sh from its own directory:
>
>     . "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
>
> and test_generic_02/12 additionally run bpftrace against the scripts in
> trace/. Neither test_common.sh nor trace/ is listed in TEST_FILES, so
> "make install" does not copy them into the install directory and every
> ublk test fails when run from there:
>
>   ./test_generic_02.sh: line 4: .../kselftest_install/ublk/test_common.sh: No such file or directory
>   ./test_generic_02.sh: line 8: _have_program: command not found
>
> The bpftrace tests are affected even when bpftrace is installed: the
> missing trace/*.bt makes bpftrace exit immediately, and the tests then
> report a skip rather than a failure, which hides the problem.
>
> Add both to TEST_FILES, matching how other selftests ship their sourced
> helpers (see kexec/kexec_common_lib.sh and zram/zram_lib.sh).
>
> Fixes: 6aecda00b7d1e1 ("selftests: ublk: add kernel selftests for ublk")
> Fixes: 723977cab4c0fd ("selftests: ublk: add generic_01 for verifying sequential IO order")
> Cc: stable@xxxxxxxxxxxxxxx # v6.15+
> Assisted-by: Kiro:claude-opus-5
> Signed-off-by: Mahmoud Nagy Adam <mngyadam@xxxxxxxxx>

On Wed, Sep 9, 2026 at 8:26 AM Mahmoud Nagy Adam <mngyadam@xxxxxxxxx> wrote:
>
> Every ublk test script sources test_common.sh from its own directory:
>
>     . "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
>
> and test_generic_02/12 additionally run bpftrace against the scripts in
> trace/. Neither test_common.sh nor trace/ is listed in TEST_FILES, so
> "make install" does not copy them into the install directory and every
> ublk test fails when run from there:
>
>   ./test_generic_02.sh: line 4: .../kselftest_install/ublk/test_common.sh: No such file or directory
>   ./test_generic_02.sh: line 8: _have_program: command not found
>
> The bpftrace tests are affected even when bpftrace is installed: the
> missing trace/*.bt makes bpftrace exit immediately, and the tests then
> report a skip rather than a failure, which hides the problem.
>
> Add both to TEST_FILES, matching how other selftests ship their sourced
> helpers (see kexec/kexec_common_lib.sh and zram/zram_lib.sh).
>
> Fixes: 6aecda00b7d1e1 ("selftests: ublk: add kernel selftests for ublk")
> Fixes: 723977cab4c0fd ("selftests: ublk: add generic_01 for verifying sequential IO order")
> Cc: stable@xxxxxxxxxxxxxxx # v6.15+
> Assisted-by: Kiro:claude-opus-5
> Signed-off-by: Mahmoud Nagy Adam <mngyadam@xxxxxxxxx>

Reviewed-by: Ming Lei <tom.leiming@xxxxxxxxx>

Thanks,