Re: [PATCH v1 3/7] arm64: dts: freescale: Add Lino iMX93

[Frank Li]

On Thu, Sep 10, 2026 at 12:16:09PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>
> Add support for the Lino iMX93 SoM, its Verdin adapter and development
> carrier board.
>
> The SoM is available in two variants, with i.MX91 or i.MX93 SoC, using
> the same PCB (the two chips are pin to pin compatible), to avoid
> duplication create a common dtsi to share commonalities.
>
...
> +};
> +
> +&gpio1 {
> +	gpio-line-names =
> +		"LINO_P18",
> +		"LINO_P16",
> +		"PMIC_I2C_SCL",
> +		"PMIC_I2C_SDA",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"LINO_P65", /* 10 */
> +		"LINO_S18",
> +		"LINO_S24",
> +		"LINO_S20",
> +		"LINO_S22",
> +		"";

Can you wrap, 4 pin pre one line to reduce LOC.

> +};
> +
...
> +
> +/* Lino I2C_1 */
> +&lpi2c1 {
> +	pinctrl-names = "default", "gpio";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	pinctrl-1 = <&pinctrl_i2c1_gpio>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;

common dtsi should already set #address-cells and #size-cells, can be
removed, please check others.

Frank