[PATCH v2 0/2] tracing: Do not clean up hiter in mmiotrace read function
From: Steven Rostedt
Date: Thu Sep 10 2026 - 16:26:27 EST
When the mmiotrace trace was first created, it allocated a descriptor in
its pipe_open() method. Since there was no pipe_close() method when it was
created (in May of 2008, and pipe_close() was added in December of 2009),
it cleaned up the allocated descriptors in the read.
Now that the clean up is in the pipe_close() method that now exists,
remove the clean up from the read as it is no longer needed.
Also simplify the code by inverting the early exit conditional into a
conditional to perform the logic and get rid of the goto.
Link: https://lore.kernel.org/all/20260715143604.14481-1-gaikwad.dcg@xxxxxxxxx/
Link: https://lore.kernel.org/all/20260721211143.36dbd559@xxxxxxxxxxxxxxxxxx/
Changse since v1: https://lore.kernel.org/linux-trace-kernel/20260721212010.76e9ed61@xxxxxxxxxxxxxxxxxx/
- Broke it up into two patches. Nothing else changed.
Steven Rostedt (2):
tracing: Do not clean up hiter in mmiotrace read function
tracing: Invert the logic in mmio_read() to get rid of the goto
----
kernel/trace/trace_mmiotrace.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)