Re: [RFC PATCH net-next v2 0/7] net: mdio: an MDIO device driver for the Airoha EN8811H

[Aleksei Sviridkin]

Two of the things I said I would do turned out not to be doable as
stated.

> It is fine. I would also add a select or depends on the PHY driver
> Kconfig stanza to link it to the MDIO_AIROHA_EN8811H driver.

Kconfig refuses it:

  symbol AIR_EN8811H_PHY is implied by MDIO_AIROHA_EN8811H
  symbol MDIO_AIROHA_EN8811H is implied by AIR_EN8811H_PHY
  error: recursive dependency detected!

The MDIO stanza already carries imply AIR_EN8811H_PHY, and that is the
direction worth having, since the MCU driver on its own drives nothing.
A select from the PHY side would be wrong anyway: a board that
describes the chip as a plain PHY has no use for the MCU driver. It
stays as it is unless you want the two swapped.

> The location is fine. MAINTAINERS need to list it. What you might want
> to do is list it twice, once in the PHY driver MAINTAINERS record, and
> again in the MDIO driver section.

There is no PHY driver record to put it in. Neither air_en8811h.c nor
the shared air_phy_lib.c is claimed by any entry, so the header sits in
the MDIO record alone. I can add a record covering both files, but that
puts my name on code I did not write. Tell me which you would rather
see.

The address check is in and the child bus now refuses anything that is
not the address the core answers, with the node in the message:

  ethernet-phy@e: address 14 is not answered here, only 13