Re: [PATCH 2/3] HID: valve-index: Reboot headset on system power transitions
From: Mario Limonciello
Date: Thu Sep 10 2026 - 17:04:44 EST
On 9/10/26 15:52, Michal Pecio wrote:
On Thu, 10 Sep 2026 15:43:18 -0500, Mario Limonciello wrote:I do think that resetting on suspend makes a lot more sense for that exact reason. That's why my original PoC did it that way.
+/*
+ * The headset's EDID service is lost when the host disables the DisplayPort
+ * PHY during system suspend, so it needs the reboot on the way out of
+ * suspend. Doing it on the way in does not work: the headset dropping off
+ * USB is a remote-wakeup event from its hub and aborts the suspend.
+ */
The internal hub which will be quirked by the next patch, or its parent?
It has to be the internal hub if quirking it works, no?
I believe there are two separate problems here:
1. resetting the device at suspend causes instant wakeup
2. a few seconds later the system wakes up anyway
1. is solved by resetting on resume rather than suspend
2. is solved by the quirk
Questions:
Any chance that 2 also solves 1?
Would resetting on suspend be preferable, as the comment suggests?
Maybe it would, if the reset can race with DP seeing empty EDID?
That's a very good idea to see if the quirk + moving it back to suspend works.