Re: [PATCH v8 2/9] scsi: ibmvfc: add NOOP command support

[Tyrel Datwyler]

On 9/9/26 12:07 PM, Dave Marquardt via B4 Relay wrote:
> From: Dave Marquardt <davemarq@xxxxxxxxxxxxx>
> 
> Add support for handling IBMVFC_NOOP format CRQ messages from the
> VIOS partner.
> 
> Advertise the client's ability to handle NOOP commands by setting the
> IBMVFC_CAN_USE_NOOP_CMD capability in ibmvfc_set_login_info().
> 
> Handle and ignore IBMVFC_NOOP format messages in both ibmvfc_handle_crq()
> and ibmvfc_handle_scrq(). In both handlers, log a rate-limited error if a
> NOOP is received while in the IBMVFC_ACTIVE state without the partner
> having advertised IBMVFC_SUPPORT_NOOP_CMD.
> 
> In ibmvfc_handle_scrq(), also fix a typo ("Got and invalid" -> "Got an
> invalid"), add a missing return on invalid message types, and guard
> against null event pointers before processing CRQ responses.
> 
> Signed-off-by: Dave Marquardt <davemarq@xxxxxxxxxxxxx>
> ---
Acked-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>