Re: [PATCH 1/2] ASoC: mediatek: common: Propagate control and DAPM errors

From: Bui Duc Phuc

Date: Thu Sep 10 2026 - 23:02:34 EST


Hi Mark,

Thank you for your review.

>
> mt8365-afe-pcm.c has:
>
> {"HW_GAIN1_IN_CH1", "CONNSYS_I2S_CH1", "Hostless FM DL"},
>
> missing a Switch from the control. I suspect there's other errors; this
> really needs to be tested before it can be applied. Given the general
> quality of the driver here and the lack of anything constructive we're
> doing with the errors changes like this have high risk and low reward
> unless we're actually running the code.

I agree that these changes should ideally be tested on real hardware.
Unfortunately, I don't currently have any MTK boards available for
testing.

If these changes cannot be properly tested, I'm also fine with
dropping this patch.

On a related note: do MediaTek or other hardware vendors typically
provide development boards to independent upstream contributors for
testing purposes? It would make it much easier for contributors like
me to properly validate changes like this one.

Best regards,
Phuc