RE: [PATCH v7 6/9] media: chips-media: wave6: Improve debugging capabilities

[Nas Chung]

Hi, Frank.

>-----Original Message-----
>From: Frank Li <Frank.li@xxxxxxxxxxx>
>Sent: Friday, September 11, 2026 1:16 AM
>To: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
>Cc: mchehab@xxxxxxxxxx; hverkuil@xxxxxxxxx; robh@xxxxxxxxxx;
>krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
>s.hauer@xxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
>devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-imx@xxxxxxx;
>linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; jackson.lee
><jackson.lee@xxxxxxxxxxxxxxx>; lafley.kim <lafley.kim@xxxxxxxxxxxxxxx>;
>marek.vasut@xxxxxxxxxxx; Ming Qian <ming.qian@xxxxxxxxxxx>
>Subject: Re: [PATCH v7 6/9] media: chips-media: wave6: Improve debugging
>capabilities
>
>On Thu, Sep 10, 2026 at 04:38:27AM +0000, Nas Chung wrote:
>> Hi, Frank.
>>
>> >-----Original Message-----
>> >From: Frank Li <Frank.li@xxxxxxxxxxx>
>> >Sent: Thursday, September 10, 2026 5:41 AM
>> >To: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
>> >Cc: mchehab@xxxxxxxxxx; hverkuil@xxxxxxxxx; robh@xxxxxxxxxx;
>> >krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
>> >s.hauer@xxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
>> >devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
>imx@xxxxxxx;
>> >linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; jackson.lee
>> ><jackson.lee@xxxxxxxxxxxxxxx>; lafley.kim <lafley.kim@xxxxxxxxxxxxxxx>;
>> >marek.vasut@xxxxxxxxxxx; Ming Qian <ming.qian@xxxxxxxxxxx>
>> >Subject: Re: [PATCH v7 6/9] media: chips-media: wave6: Improve debugging
>> >capabilities
>> >
>> >On Fri, Sep 04, 2026 at 03:46:32PM +0900, Nas Chung wrote:
>> >
>> >media: chips-media: wave6: Add trace and debugfs
>>
>> I'll address this in v8.
>>
>> >
>> >> Add debugfs entries and trace events to provide detailed
>> >> debugging information.
>> >
>> >Nit: need extra space line here.
>>
>> OK.
>>
>> >
>> >> These enhancements help diagnose issues and improve debugging
>> >
>> >Remove "These enhancements".
>>
>> I'll remove it.
>>
>> ...
>>
>> >
>> >> +
>> >> +#ifndef __WAVE6_VPU_DBG_H__
>> >> +#define __WAVE6_VPU_DBG_H__
>> >> +
>> >> +int wave6_vpu_create_dbgfs_file(struct vpu_instance *inst);
>> >> +void wave6_vpu_remove_dbgfs_file(struct vpu_instance *inst);
>> >
>> >You add this patch 6. but call this funcation at patch 4.
>> >
>> >You need make sure each patch can build without break bisect.
>>
>> You are right that patch 4 calls what patch 6 declares.
>>
>> But the build does not break: wave6/Kconfig and wave6/Makefile are added
>in
>> patch 8, so nothing under wave6/ is compiled in patches 3-7. I built
>every
>> commit individually.
>
>Still not good yet, you can add call wave6_vpu_create_dbgfs_file() at
>patch 6, instead of patch4.
>
>You need make sure your code is built and passed at every patch. You
>can add library/makefile firstly, then enable it gradulately. But need make
>sure pass build test, some kernel CI tools build each patch and easy to
>locate the problem, if build failure at last patch, which cause some
>difficult to locate the real patch, which cause problem.

Agreed. In v8 wave6/Kconfig and wave6/Makefile will come in the first wave6
patch so every patch compiles on its own. I'll build each patch to confirm.

Thanks.
Nas.

>
>Frank
>
>>
>> Thanks.
>> Nas.
>>
>> >
>> >Frank
>> >
>> >> +
>> >> +#endif /* __WAVE6_VPU_DBG_H__ */
>> >> --
>> >> 2.31.1
>> >>