Re: [PATCH v8 3/3] arm64: dts: qcom: shikra: Enable USB controllers and primary Type-C support

[Abel Vesa]

On 26-09-11 11:37:20, Komal Bajaj wrote:
> From: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> 
> Enable USB controller nodes across Shikra platform device trees and add
> primary Type-C controller wiring for CQM/CQS variants.
> 
> - Enable USB controller blocks for shikra-cqm-evk, shikra-cqs-evk
>   and shikra-iqs-evk
> - Add Type-C support on the primary controller for CQM/CQS boards,
>   including role-switch and connector integration
> 
> Co-developed-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts  | 43 ++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi | 41 ++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts  | 43 ++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/shikra-evk.dtsi     | 12 ++++++++
>  arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts  | 23 +++++++++++++++
>  5 files changed, 162 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> index b112b21b1d79..286ea46d0c36 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> @@ -23,6 +23,14 @@ chosen {
>  	};
>  };
>  
> +&pm4125_hs_in {
> +	remote-endpoint = <&usb_1_dwc3_hs>;
> +};
> +
> +&pm4125_ss_in {
> +	remote-endpoint = <&usb_qmpphy_out>;
> +};
> +
>  &remoteproc_cdsp {
>  	firmware-name = "qcom/shikra/cdsp.mbn";
>  
> @@ -57,3 +65,38 @@ &sdhc_1 {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {
> +	dr_mode = "otg";
> +};
> +
> +&usb_1_dwc3_hs {
> +	remote-endpoint = <&pm4125_hs_in>;
> +};
> +
> +&usb_1_hsphy {
> +	vdd-supply = <&pm4125_l12>;
> +	vdda-pll-supply = <&pm4125_l13>;
> +	vdda-phy-dpdm-supply = <&pm4125_l21>;
> +
> +	status = "okay";
> +};
> +
> +&usb_qmpphy {
> +	vdda-phy-supply = <&pm4125_l8>;
> +	vdda-pll-supply = <&pm4125_l13>;
> +
> +	status = "okay";
> +};
> +
> +&usb_qmpphy_out {
> +	remote-endpoint = <&pm4125_ss_in>;
> +};
> +
> +&usb_2_hsphy {
> +	vdd-supply = <&pm4125_l12>;
> +	vdda-pll-supply = <&pm4125_l13>;
> +	vdda-phy-dpdm-supply = <&pm4125_l21>;
> +
> +	status = "okay";
> +};

To keep alphabetical order, please move usb_2_hsphy above usb_qmpphy.

Same comment applies to other files.