Re: [PATCH net-next v2 1/5] net: Add netdev_config helpers
From: Breno Leitao
Date: Fri Sep 11 2026 - 05:34:48 EST
On Thu, Sep 10, 2026 at 08:09:01PM +0200, Björn Töpel wrote:
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
>
> netdev_config manipulation will become slightly more complicated
> soon and will be used by both ethtool and the queue API.
> Encapsulate the logic in helper functions.
>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxx>
Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>
> +void __netdev_free_config(struct netdev_config *cfg)
> +{
> + kfree(cfg);
> +}
When I read this one, I was expecting __netdev_free_config() to "become
more complicated", but, it continues to alway be a single kfree(). How
is this helper useful?
--breno