Re: [PATCH 3/3] usb: xhci-pci: Put PWRON_POLARITY on a defined state

From: Michal Pecio

Date: Fri Sep 11 2026 - 14:20:08 EST


On Fri, 11 Sep 2026 10:58:27 -0300, Fabio Estevam wrote:
> Hi Michal,
>
> On Wed, Sep 9, 2026 at 11:43 AM Michal Pecio <michal.pecio@xxxxxxxxx> wrote:
> >
> > On Wed, 9 Sep 2026 09:58:42 -0300, Fabio Estevam wrote:
> > > Currently, TUSB73X0_PWRON_POLARITY is set when the
> > > "ti,pwron-active-high" is present.
> > >
> > > However, when "ti,pwron-active-high" is absent, its status could
> > > have been set previously by a bootloader or by a previous running
> > > kernel.
> >
> > or by EEPROM.
> >
> > Do they bother to put the chip in a wrong, non-default state at
> > boot?
>
> I was working on a hardware bring-up with the TUSB7320, and I never
> saw it happen.

That could practically only happen due to a bug. Seems more likely
that EEPROM or boot FW may set the bit because it's required by the
board and then the kernel could clear it for lack of knowledge.

If there is ever a need to support clearing the bit, it would better
be done by checking if the DT property is specified at all, and only
then tweaking the bit accordingly. Otherwise, leave it alone.

Regards,
Michal